Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 165
    • Merge requests 165
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !57171

Track Collection Merger: use ConstDataVector for VIEW container with correct semantics. The const_cast is needed due to summaries

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:Merge_cleanup into master Sep 30, 2022
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 2
  • Track Collection Merger: use ConstDataVector for VIEW container with correct semantics.

  • Here we never set VIEW to false as having dup of all Trk::Track is prb too much ...

  • The const_cast is needed actually because we create/update summaries. make this clear (aka "no magic" comment needed)

  • @tstreble this is the code that can benefit if we move all the "late" summaries to the Particle Creator, aka the non-basic ones

  • Ping also @sroe who told me that the above is discussed, and if done I hope we will be able also to clean up the Summary tool ...

@fwinkl , @ssnyder as this appears (and the issue is not solved in the MR) in the thread safery checking build.

Relates to (but does not completely fix) ATLASRECTS-7250.

Edited Sep 30, 2022 by Frank Winklmeier
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: Merge_cleanup