Skip to content

Track Collection Merger: use ConstDataVector for VIEW container with correct semantics. The const_cast is needed due to summaries

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:Merge_cleanup into master

  • Track Collection Merger: use ConstDataVector for VIEW container with correct semantics.

  • Here we never set VIEW to false as having dup of all Trk::Track is prb too much ...

  • The const_cast is needed actually because we create/update summaries. make this clear (aka "no magic" comment needed)

  • @tstreble this is the code that can benefit if we move all the "late" summaries to the Particle Creator, aka the non-basic ones

  • Ping also @sroe who told me that the above is discussed, and if done I hope we will be able also to clean up the Summary tool ...

@fwinkl , @ssnyder as this appears (and the issue is not solved in the MR) in the thread safery checking build.

Relates to (but does not completely fix) ATLASRECTS-7250.

Edited by Frank Winklmeier

Merge request reports