Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 183
    • Merge requests 183
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !60010

Improved Random number Seeding for ParticleGun

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:ParticleGunRobustSeeding_master into master Jan 23, 2023
  • Overview 8
  • Commits 2
  • Pipelines 2
  • Changes 27

Previously the ParticleGun single particle generator used the inital seed value taken from the (thread-unsafe) random number service Configurable to set the seed for the python random number generator during initialize. No per-event reseeding was done. This has been replaced by using the same random seed calculation as in C++ (via a wrapper function) and re-seeding the python random number generator every event. This means that the dependence on the random number service itself is no longer required.

This is a prerequisite for running ParticleGun in ComponentAccumulator-based jobs.

Tagging @ewelina.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ParticleGunRobustSeeding_master