Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !61526

Update muon CP alg sequence to very latest Run 3 recommendations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Teng Jian Khoo requested to merge khoo/athena:master-MuonCPAlg-2023Recs into master Mar 14, 2023
  • Overview 27
  • Commits 2
  • Pipelines 2
  • Changes 3

As is starting to be a trend, the CP alg configs are lagging behind the CP group recommendations (see !61011 (merged)).

If they are not kept up to date, having the central implementation is self-defeating. Changing two python lines is not any more effort than requesting the calib area be updated. Tagging @vimartin and @hrussell in the hopes that we can get some sort of process going such that propagating updates to the XAnalysisAlgorithms config is bound tightly to releasing recommendations. A quick search for related MRs only shows an AnalysisTop update, so it seems that there was no change needed in the MCP code. This suggests that we can't depend on anything in Git to flag the need for such updates, and the solution has to be some sort of procedural one.

I'll also note that this silences many many warnings like

CollectionContainer       WARNING Could not find any SF period in Central matching the run number 430536
CollectionContainer       WARNING Could not find any SF period in CentralLowPt matching the run number 430580

which I was unable to modify with message level settings, which was the catalyst for my finding the discrepancy.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-MuonCPAlg-2023Recs