Add ghost merging alg

This MR adds a new algorithm to JetAnalysisAlgorithms which combines multiple ghost track collections into one. This is useful to combine standard and LRT ghost tracks to be used by downstream algorithms.

Tagging @dguest who may be interested

added 1 commit

• 882a3ed3 - Update copywrite

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithmsDict.h
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/JetGhostMergingAlg.h
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/selection.xml
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/Root/JetGhostMergingAlg.cxx

Adding @krumnack ,@tadej ,@pagessin as watchers

added Analysis JetEtmiss analysis-review-required master review-pending-level-1 labels

marked this merge request as draft

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithmsDict.h
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/JetGhostMergingAlg.h
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/selection.xml
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/Root/JetGhostMergingAlg.cxx

Adding @krumnack ,@tadej ,@pagessin as watchers

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

added 1 commit

• 90d3d3f6 - Make ghostTrackAcc not static

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

This merge request affects 4 files:

• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithmsDict.h
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/JetGhostMergingAlg.h
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/JetAnalysisAlgorithms/selection.xml
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms/Root/JetGhostMergingAlg.cxx

Adding @krumnack ,@tadej ,@pagessin as watchers

CI Result SUCCESS (hash 882a3ed3)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69784]

CI Result SUCCESS (hash fe91a31f)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69783]

CI Result SUCCESS (hash 90d3d3f6)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69786]

Hi @jburzyns

I am just wondering if it's not a waste of memory to add in memory a collection which is the merge of two other collections in memory? Or the vectors just contain pointers to objects and therefore the memory overhead is negligible?

Giovanni (AR)

Moving to review-user-action-required while there are unresolved threads.

Jason (L1)