Skip to content
Snippets Groups Projects

L1Calo eFEX Simulation: deal correctly with floating precision rounding effects

Merged Will Buttinger requested to merge will/athena:efexSCPrecisionFix into 23.0
All threads resolved!

deal correctly with floating precision rounding effects in converting energy to et in units of 12.5MeV

This MR is intended as a prereq of the outstanding MR !62722 (merged) which will also see this change implemented. Here I'm breaking out this change to factorise out the effects on the reference files, which I will deal with here.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • James Beacham resolved all threads

    resolved all threads

  • The changes look okay and there are no issues with the CI. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • Jennifer Roloff mentioned in commit b427151c

    mentioned in commit b427151c

  • Adam Edward Barton mentioned in merge request !64077 (merged)

    mentioned in merge request !64077 (merged)

  • Please register or sign in to reply
    Loading