Automatically turn DQ.Steering.doTauMon and DQ.Steering.HLT.doJet to false for cosmic input
Currently, we have update AMI tags (to toggle two pre-exec) every time ATLAS changes from cosmics to collisions and back. How crazy!
This MR auto-configures these two flags based on the input (as we do it for many other cases).
Merge request reports
Activity
added 23.0 Core DQ Trigger review-pending-level-1 labels
cc @jmaurer for info ...
added Run3-DataReco-output-changed label
❌ CI Result FAILURE (hash c97f0832)Athena externals ✅ cmake ✅ make ✅ tests ⭕ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 74881]- Resolved by Julien Maurer
The reason for the CI-failure is two-fold:
- The x and f tags used at the Tier0 explicitly set
flags.DQ.Steering.HLT.doJet=True
while in the q-tests it isfalse
(default). So we are not testing what we are running in production. This is bad. - The HLT Jet Monitoring modifies the AOD content. This went undetected because we are not testing it (point 1). This is even worse. Opened ATR-27980 ....
- The x and f tags used at the Tier0 explicitly set
Changing label to review-user-action-required until (1) and (2) are resolved. Please change back when ready for review. Clara (L1)
added review-user-action-required label and removed review-pending-level-1 label
mentioned in merge request !61534 (merged)
removed Run3-DataReco-output-changed label
added review-pending-level-1 label and removed review-user-action-required label
✅ CI Result SUCCESS (hash c97f0832)Athena externals ✅ cmake ✅ make ✅ tests ✅ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 75646]added review-user-action-required label and removed review-pending-level-1 label
- Resolved by Julien Maurer
Changes look good to me now. However, there is still an open thread. Can that be closed? Then i can approve afterwards. (Do not forget to set the review-pending-level-1 label if the thread gets closed without a new commit)
Cheers L1
removed review-user-action-required label
added review-pending-level-1 label
added review-approved label and removed review-pending-level-1 label
added review-approved-tier0 label
added review-approved-point1 label
mentioned in commit 9996d97b
mentioned in merge request !64790 (merged)