Skip to content

CP::ShowerDepthTool Updates, main branch (2023.08.21.)

Attila Krasznahorkay requested to merge akraszna/athena:ShowerDepthToolFixes-main-20230821 into main

Cleaned the interface and implementation of CP::ShowerDepthTool a little.

  • Primitive types are now passed to the tool by value instead of const reference;
  • Made the tool use std::unique_ptr for managing the memory of its histograms;
  • Added the ability to print (warning) messages from the class;
  • Re-wrote the protection against out-of-bounds interpolation in the code to not hardcode any properties of the underlying TH2 histogram.

This MR has a rich history behind it. I myself got involved through ATLASRECTS-7711, but the same issue was reported on previously also in ATLASG-2486. The thing is, I just don't like how !61779 (merged) fixed this issue. So this is my proposal for how I think it should work instead.

Pinging @christos, @gmarchio.

Merge request reports