put back the bytestream converter packages for Muon calibration stream

requested review from @zyan and @diehl

assigned to @emoyse and @jojungge

Jenkins please retry a build

This merge request affects 2 packages:

MuonSpectrometer/MuonCalib/MuonCalibStream/MuonCalibStreamCnv
MuonSpectrometer/MuonCalib/MuonCalibStream/MuonCalibStreamCnvSvc

Affected files list will not be printed in this case

Adding @rosati ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added MuonSpectrometer main labels

CI Result SUCCESS (hash 613935ef)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 76719]

added 2 commits

95784496 - add ATLAS copyright and remove unused import module
dfe7fe3a - remove unused import module

Compare with previous version

Dear @zyan, the atlas bot does not seem to be a member in your fork. Please add the atlas bot as a Developer to your fork.

Cheers, Steffen (L1)

Hi Steffen, I have added the atlas bot as a Developer into my Athena fork. Best, Zhen

added 1 commit

5a04d0ab - Add possibility to avoid configuring BS

Compare with previous version

Hi @emoyse, thanks a lot for your update. I am able to see the reconstructed standalone Muon tracks with your job options.
By quickly browsing the printed log file, I found some MuonEventCnvTool errors and TGC ElementID warnings. Do you know how severe those errors and warnings are? Does this mean the part of MDT and TGC cabling was wrong? I put the typical errors below.

ToolSvc.EventCnvSuperTool.MuonEventCnvTool ERROR Could not find matching PRD container for this ROT. ROT will be written out in incomplete state. Dumping ROT: MdtDriftCircleOnTrack { Trk::RIO_OnTrack { identifier = 0x612d422000000000 position = (Trk::LocalParameters : (4.431) - key: 1(10000) has Error Matrix: 0.00941188 } PrepRawData: MdtPrepData { PrepRawData object Identifier 0x612d422000000000 Local Position = ((7.5000, 0.0000)), Local Covariance = ((17.6400)), Collection Hash: 65535 Index in collection: 65535 RDO List = [0x612d422000000000 ], TDC = 235, ADC = 173, status = 1, } End MdtPrepData

DriftTime: 97.4821 Status: 0 Sagged surface: NONE Position along wire: 212.131, local angle=4.34613 }

TgcRdoToTgcPrepData.TgcPrepDataProviderTool WARNING ElementID not found for sub=104 rod=9 ssw=8 slb=5 bitpos=47 orFlag=0 TgcRdoToTgcPrepData.TgcPrepDataProviderTool WARNING Muon::TgcRdoToPrepDataToolMT::decodeTrackletEIFI OfflineID not found for subDetectorId=104 rodId=9 sswId=8 slbId=5 slbType=5 subMatrix=0 bitpos=46 isStrip=1 isAside=0 isForward=0 slot=16 isBackward=0

Meanwhile, when I ran the job, I saw some errors related to NSW and ID(SCT and Pixel). Do we have a method to disable them since there are no NSW and ID data in the Muon Calibration stream?

VarHandle(StoreGateSvc...Measurements[1265704919])WARNING StoreGate/src/VarHandleBase.cxx:848 (voidSG::VarHandleBase::typeless_dataPointer_impl(bool)): could not get proxy for key STGC_Measurements VarHandle(StoreGateSvc...Measurements[1115503214])WARNING StoreGate/src/VarHandleBase.cxx:848 (voidSG::VarHandleBase::typeless_dataPointer_impl(bool)): could not get proxy for key MM_Measurements Pi...PixelByteStreamErrorDetectorElementStatusTool ERROR Did not get bytestream error container with key 'StoreGateSvc+PixelByteStreamErrs'

I found that all ADC and TDC counts of BMG chambers and BIS7A chambers (HPTDC type) were divided by 4 twice and therefore no BMG hits were found in the reconstructed muon track due to the 50 ADC cut. @jojungge, could you point me where the HPTDC adc and tdc counts were handled in the standard reconstruction config? I saw that the calibration stream converter (MdtPRDContCalibStreamCnv) has considered this HPTDC issue in lines 175-181. https://gitlab.cern.ch/zyan/athena/-/blob/restore-calib/MuonSpectrometer/MuonCalib/MuonCalibStream/MuonCalibStreamCnv/src/MdtPRDContCalibStreamCnv.cxx

I see that the HPTDC ADC/TDC counts are also divided by 4 here: MdtRdoToPrepDataToolMT.cxx However, calibstream MDT bytestream is converted directly to PRD, bypassing RDO, so I would not expect this code to would not be executed for calibstream