24.0 TRT high threshold tune

Significantly improves the modelling of the number of TRT high-threshold hits, by updating the digitisation parameters. The threshold values were tuned by comparing MC with Run 3 low-mu data. The pile-up dependence is taken into account in the pile-up overlay correction values. These have been tuned using several Run 3 runs at usual pile-up conditions.

A summary of the results was presented in the Simulation Group Meeting on Feb. 13: https://indico.cern.ch/event/1381473/contributions/5806705/attachments/2800131/4884883/TRT_mc23e_tune_2014_02_13.pdf

More details can be found in these slides by @hadenizl: https://indico.cern.ch/event/1335684/contributions/5622451/attachments/2795220/4876744/TrtDays_7Feb2024_haluk.pdf

The impact on tracking is negligible. A significant change is expected for the number of TRT HT hits and derived quantities like eProbability_HT, which is used for example in electron identification, photon reconstruction and tau electron veto. In https://its.cern.ch/jira/browse/ATLPHYSVAL-1008 the impact has been validated: everything looks as expected.

If possible, this change should go into the release for MC23e, since it significantly improves the modelling of electron identification observables. No significant side effects have been observed in the PhysVal checks.

Tagging: @beddall, @ludovica, @kristin, @ademaria, @sineadf, @martindl

added 24.0 main urgent labels

This merge request affects 2 packages:

• InnerDetector/InDetDigitization/TRT_Digitization
• InnerDetector/InDetRawAlgs/InDetOverlay

Affected files list will not be printed in this case

Adding @tadej ,@calfayan ,@cgrefe ,@sroe ,@goetz ,@jchapman ,@ahaas ,@tkharlam as watchers

added Digitization InnerDetector Overlay review-pending-level-1 labels

added Run2-DataOverlay-output-changed Run2-MCOverlay-output-changed Run2-MCReco-output-changed Run3-MCOverlay-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 5a481dbc)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5622] (remote access info)

@cgrefe Just double checking these output changes look correct to you. If so I'll approve so the refs can be updated by sc. L1

Hi @cgrefe, can we make this fully configurable so at least the Run 2 output does not change, but ideally also old MC campaigns would not change.

The default can be the latest one, but old campaigns should not change.

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

Hi, thanks @beddall and @cgrefe for this MR! However before approving it for 24, we need to get the official ok from PC and all the CP groups. I expect this will be discussed today at PC meeting. Cheers, Marilena

removed main label

added frozen-tier0-violating label

removed urgent label

resolved all threads

All affected CP groups have agreed that this change should go in for MC23e. Please go ahead with the merge.

removed review-user-action-required label

added review-pending-level-1 label

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetDigitization/TRT_Digitization
• InnerDetector/InDetRawAlgs/InDetOverlay

Affected files list will not be printed in this case

Adding @calfayan ,@tkharlam ,@goetz ,@sroe ,@tadej ,@cgrefe ,@ahaas ,@jchapman as watchers

CI Result FAILURE (hash 5a481dbc)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6904] (remote access info)

removed review-pending-level-1 label

Today in the OAB meeting it was agreed that this merge request should be included for MC23e production (see https://indico.cern.ch/event/1397669/)

resolved all threads

added review-pending-level-1 label

If the changes in the output are correct now, the reference files need to be updated by the experts.

removed review-pending-level-1 label

added review-user-action-required label

We will have a brief discussion in the reconstruction meeting today and we will proceed with the updates of the references afterwards (might want to re-run the CI to produce the new references, since we had a few updates to the references in the meantime)

added offline-sw-review-approved label

added 776 commits

• 5a481dbc...3d2ef80d - 774 commits from branch atlas:24.0
• 9d75dc7e - Update TRT high-threshold corrections for pile-up overlay
• 430df3c2 - Update TRT high-threshold tune in digitisation

Compare with previous version

Jenkins please retry a build

mentioned in merge request !68758 (merged)

Jenkins please retry a build

This merge request affects 2 packages:

• InnerDetector/InDetDigitization/TRT_Digitization
• InnerDetector/InDetRawAlgs/InDetOverlay

Affected files list will not be printed in this case

Adding @tkharlam ,@goetz ,@cgrefe ,@ahaas ,@calfayan ,@tadej ,@sroe ,@jchapman as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 430df3c2)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7112] (remote access info)

If the changes are now fully approved, please update the references.

~L1

removed review-pending-level-1 label

added review-user-action-required label

mentioned in commit cgrefe/athena@8808dfc5

added 1 commit

• 8808dfc5 - updated references for MR !69406 (merged)

Compare with previous version

Jenkins please retry a build

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 4 packages:

• InnerDetector/InDetDigitization/TRT_Digitization
• InnerDetector/InDetRawAlgs/InDetOverlay
• Tools/PROCTools
• Tools/WorkflowTestRunner

Affected files list will not be printed in this case

Adding @sroe ,@goetz ,@tkharlam ,@jchapman ,@ahaas ,@pagessin ,@cgrefe ,@calfayan ,@tadej as watchers

added Tools review-pending-level-1 labels and removed review-user-action-required label

CI Result SUCCESS (hash 8808dfc5)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7129] (remote access info)

Since all disucssions have been resolved and all the required approval steps were done + the CI succeeds now, I approve for L1.

removed review-pending-level-1 label

added review-approved label

added review-approved-tier0 label