Update MergeConfigs.py - new feature to select specific folders for config...
Update MergeConfigs.py - new feature to select specific folders for config merging (useful for running tests on subset of the tier0 monitoring)
Also adds a fix for the case where the hash of the release cannot be determined (as is the case if the user has setup their own cmake project)
Merge request reports
Activity
added 24.0 DQ review-pending-level-1 labels
CI Result SUCCESS (hash d534cbc3)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6391] (remote access info)added review-approved label and removed review-pending-level-1 label
added review-approved-tier0 label
mentioned in commit ff11d6ac
mentioned in merge request !69851 (merged)
Hi @will - this completely broke "normal" configuration builds (i.e. those not using a whitelist), because
''.split(':')
is not an empty list, but['']
.I would also prefer not to have a blacklist mechanism that uses command line arguments and a whitelist mechanism that uses environment variables. I assume the reason you are using envvars is because passing variables to code in the build is a bit tricky. I wonder if we can achieve this with cmake options instead.
Anyway I am going to make a MR to fix the blocker here - I would appreciate your thoughts on making a test for this script so this doesn't happen again - and then we should talk about the interface to your whitelisting.
Apologies for not having tested my change on the situation where I didn't have a whitelist - to be honest I was relying on there being an existing CI test that would catch any such issue, as I introduced the whitelist precisely so I could test some DQ stuff without waiting for ages for the whole lot to run.
At least the fix is an easy one!
mentioned in merge request !70181 (merged)