Consistent use of TRT straw status in LocalOccupancy and DriftCircle creation
Remove access to TRT straw status permanent, and rely only on the usual straw status - consistent with the TRT drift circle creation. Fixes ATLASRECTS-8006.
Merge request reports
Activity
This merge request affects 1 package:
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
This merge request affects 2 files:
- InnerDetector/InDetRecTools/TRT_ElectronPidTools/TRT_ElectronPidTools/TRT_LocalOccupancy.h
- InnerDetector/InDetRecTools/TRT_ElectronPidTools/src/TRT_LocalOccupancy.cxx
added Egamma InnerDetector main review-pending-level-1 labels
❌ CI Result FAILURE (hash 7238a48f)Athena externals ✅ cmake ✅ make ✅ tests ⭕ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10417] (remote access info)Code changes look good, but overlay output differences to be discussed, so setting review-user-action-required
L1 shifter
added review-user-action-required label and removed review-pending-level-1 label
- Resolved by Christos Anastopoulos
I think that some difference is expected, since the TRT overlay uses the TRT_LocalOccupancy tool for its occupancy-dependent corrections.
@cgrefe have you checked that the differences are actually small ? I would like to make sure that they do not spoil the TRT tuning just before we build the release for mc23e reconstruction...
Tommaso
added offline-sw-review-approved label
added RC Attention Required label
removed review-user-action-required label
added review-pending-level-1 label
This merge request affects 1 package:
- InnerDetector/InDetRecTools/TRT_ElectronPidTools
This merge request affects 2 files:
- InnerDetector/InDetRecTools/TRT_ElectronPidTools/TRT_ElectronPidTools/TRT_LocalOccupancy.h
- InnerDetector/InDetRecTools/TRT_ElectronPidTools/src/TRT_LocalOccupancy.cxx
❌ CI Result FAILURE (hash 7238a48f)Athena externals ✅ cmake ✅ make ✅ tests ⭕ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 10571] (remote access info)removed review-pending-level-1 label
added review-user-action-required label
removed review-user-action-required label