DerivationFrameworkTau: gcc14 warning

Fix use of remove_if --- have to call erase() to actually remove the elements. (erase_if doesn't work here since we're not scanning the entire vector.)

Also fixes cppcheck warning seen on !77034 (merged).