Skip to content

PyModules Fixes, master branch (2019.05.31.)

Since this package allows a bunch of python modules to build themselves in parallel, we need to be careful with how we install them from their temporary installation directory into the CMake build directory.

Instead of doing that installation separately with each python module's build, the package now has a single target that does this installation. Which only runs once all the python modules finished building/installing themselves into that temporary installation directory.

This is to fix the build issues seen in !470 (merged), !487 (merged) and !488 (merged).

Eventually the PyAnalysis package should also inherit some of these types of updates, but for now I only wanted to fix PyModules...

CC-ing @fwinkl, @ssnyder, @bmorgan, @jchapman and @pagessin, who, one way or another, are waiting for this fix...

Merge request reports