Submaps are not unrolled in `--gen-consts` even if `include == True`

As it is, the include attribute of a submap item has no effect on the generated constants file. The behavior I expect is that it should be unrolled (the code actually has a comment that suggests it is a considered behavior but not enabled by default).

@adbyszuk @vnappi

mentioned in merge request !63

So, unroll or not unroll ?

The advantage of not unrolling constants is that the software doesn't have to be updated if the designer decide to change the include flag.

Why do you expect unrolling ?

We have quite a complex memory map that is only going to grow.
To keep our sanity we split it into multiple files that we want to include in our top yaml file.
You can see it here: https://gitlab.cern.ch/cce/fgc4/-/tree/diot_sb_v3_porting/mb?ref_type=heads

I don't think we can do that without unrolling, am I wrong?

I am not sure to understand why you require unrolling. You can generate the consts of the submap and use them. In some cases, it can even avoid replication of constants.

@adbyszuk

May I ask what was the conclusion for this issue?

Hi,

Since there's some pushback I'm not going to force it. I can use method recommended by Tristan. It's a bit suboptimal for my use case, but it's nothing serious.