Rational logic: if a new physical activity is created, it should be displayed on the occupants… dropdown options...
-
6dc3eb1e · Merge branch 'feature/improvements' into 'master'
- ... and 1 more commit. Compare 7d86a5c2...6dc3eb1e
Many thanks @mmanzine for the work done in this MR!...
Nothing else to add
Let's keep this file as it is for the time being, keeping in mind that in the future we might want to move these values to proper environment varia...
Sure thing, done. Let me know if you have additional feedback or comments.
-
27423e48 · removed comments
This could perhaps be removed? Same for the similar commented instructions below?
Refined and cleaned up the code; all the updates made here are now focused on UI changes.
Removed the test return block, needed just for local testing.
Rollback done to the version without this change (not needed in this UI-focused MR)
Rollback done to the version without this change (not needed in this UI-focused MR)
-
43838828 · removed temporary testing return
- ... and 2 more commits. Compare c5471165...43838828
Great that you've created a separate branch with a copy of everything that is not strictly related to this MR. That way, in the future, in case it ...
Ok, I agree on moving it to the variables in CI/CD and add instructions on the README how to properly read and declare these variables for local te...
Sure, but will we not use this withCredentials
prop? Given that it was not commented out in the previous version, and that this MR is purely doing ...
Sorry, I've simply closed the threads in which I have applied the suggested change. Feel free to re-open them if they require discussion.
Sorry, didn't understand your answer. What do you mean by "in official MR"? Is official meaning production, when in master?