Skip to content
Snippets Groups Projects
Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Rational logic: if a new physical activity is created, it should be displayed on the occupants… dropdown options...

Andre Henriques's avatar
Andre Henriques's avatar
accepted merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard
Luis Aleixo's avatar
approved merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard
Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Many thanks @mmanzine for the work done in this MR!...

Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Nothing else to add

Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Let's keep this file as it is for the time being, keeping in mind that in the future we might want to move these values to proper environment varia...

Matteo Manzinello's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Sure thing, done. Let me know if you have additional feedback or comments.

Matteo Manzinello's avatar
Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

This could perhaps be removed? Same for the similar commented instructions below?

Matteo Manzinello's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Refined and cleaned up the code; all the updates made here are now focused on UI changes.

Matteo Manzinello's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Removed the test return block, needed just for local testing.

Matteo Manzinello's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Rollback done to the version without this change (not needed in this UI-focused MR)

Matteo Manzinello's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Rollback done to the version without this change (not needed in this UI-focused MR)

Matteo Manzinello's avatar
Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Great that you've created a separate branch with a copy of everything that is not strictly related to this MR. That way, in the future, in case it ...

Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Ok, I agree on moving it to the variables in CI/CD and add instructions on the README how to properly read and declare these variables for local te...

Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Sure, but will we not use this withCredentials prop? Given that it was not commented out in the previous version, and that this MR is purely doing ...

Matteo Manzinello's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Sorry, I've simply closed the threads in which I have applied the suggested change. Feel free to re-open them if they require discussion.

Luis Aleixo's avatar
commented on merge request !15 "Improvements from feedback" at CAiMIRA / CAiMIRA Data Service / Data Admin Dashboard

Sorry, didn't understand your answer. What do you mean by "in official MR"? Is official meaning production, when in master?