Add get* commands to MetaInfo history

Running getDimuonSpectrum doesn't add a new entry to the history. So we get:

$ printMetaInfo M2_applyDimuonSkim/getDimuonSpectrum/ZZ/0.root history
submit /nfs/dust/cms/user/mourelou/darwin/campaigns/friends-0019/.dag/run_MC_Zmmg/mergeNtuples /pnfs/desy.de/cms/tier2/store/user/paconnor/ZZ_TuneCP5_13TeV-pythia8/7fa8ec0c1918_Zmmg_RunIISummer20UL18MiniAODv2-106X_upgrade2018_realistic_v16_L1v1-v2 /nfs/dust/cms/user/mourelou/darwin/campaigns/friends-0019/M1_mergeNtuples/ZZ/ /nfs/dust/cms/user/mourelou/darwin/Installer/tables/jetvetomaps/eff_map_UL18.root true -j 40 -f
submit /nfs/dust/cms/user/mourelou/darwin/campaigns/friends-v5-oct-24/.dag/run_MC_Zmmg/applyDimuonSkim /nfs/dust/cms/user/mourelou/darwin/campaigns/friends-0019/M1_mergeNtuples/ZZ /nfs/dust/cms/user/mourelou/darwin/campaigns/friends-v5-oct-24/M2_applyDimuonSkim/ZZ/ 15 10 -f

Notice how getDimuonSpectrum isn't in the list.

Darwin's example04 does the right thing:

$ printMetaInfo test/Hists04_friends/0.root history
parallel /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple01/example01 Ntuple01/ true 4 2016 AK CHS HIPM -f
parallel /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple02_friends/example02 "/home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple01/0.root /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple01/1.root" Ntuple02_friends/ ./filters/Phase0.json -F
parallel /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple03_friends/example03 "/home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple02_friends/0.root /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple02_friends/1.root /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple02_friends/2.root" Ntuple03_friends/ -s -F
./example04 "/home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple03_friends/0.root /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple03_friends/1.root /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple03_friends/2.root /home/louis/Documents/Darwin/Installer/build/Darwin/test/Ntuple03_friends/3.root" /home/louis/Documents/Darwin/Installer/build/Darwin/test/Hists04_friends/0.root

So this is an issue only in Core. According to @paconnor all Core getters are potentially affected.

All getters should call Check:

metainfo.Check(config);

I wonder if this can be automated...

(Originally opened as #94 (moved).)

added changepatch statusto do typesoftware labels

All getters should call Check:

metainfo.Check(config);

I wonder if this can be automated...

Certainly---this would however require changes upstream.

Currently, the MetaInfo class has two constructors:

• one to the very first initialisation, which takes the tree and a Boost Property Tree;
• one for updates of an existing n-tuple with metainfo, which only takes the tree.

In the latter case, the comparison between the internal metainfo (retrieved via TTree::GetUserInfo()) and the input config file is done via MetaInfo::Check(). The internal metainfo is retrieved automatically in the constructor of the Metainfo, while the input config file is provided as an argument of MetaInfo::Check().

We could have one single constructor, with a third argument (enum Initialisation { first, update };?) to specify if this is a very first initialisation or an update.

Self-answering: there might even be no need for a third argument. It is likely sufficient to check the result of TTree::GetUserInfo(). If it's emtpy, then it's a first initialisation; else it should be Check()ed.

See also Proto/Darwin#82