Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • P Ph2_ACF
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • cms_tk_ph2
  • Ph2_ACF
  • Merge requests
  • !169

Small fixes for SLC6 and Antenna operations

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Delcourt requested to merge delcourt/Ph2_ACF:SLC6_update into Dev Dec 01, 2020
  • Overview 5
  • Commits 2
  • Pipelines 2
  • Changes 5

Dear Ph2_ACF developers,

While setting up a hybrid test system on a SLC6 based system, and compiling the code for antenna tests, I found a few bugs that might interest you.

  • SLC 6 compatibility (even if I was told that support for this distribution might have been dropped, I don't think these changes would harm the code) :
  • Added compiler flags to ignore warnings occuring while compiling outdated external libraries preventing to build Ph2_ACF.
  • Added include to TCPClientBase.cc .
  • Antenna compatibility :
  • Changed two "Start" and "Stop" methods to "StartBoard" and "StopBoard".
  • src/feh_2s_test.cc : updated Find Open method name
  • miniDAQ :
  • Added line to cic aligner section to allow miniDAQ to run with CIC

Best regards, Martin

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: SLC6_update