Skip to content
Snippets Groups Projects

Adding Steinahart parametrization to convert thermistor value to T

Closed Alessandro Rossi requested to merge rossia/Ph2_ACF:tempReadoutUpdate into Dev
2 unresolved threads

The title say it all, with this merge we include the Steinahart parametrization as extracted from thermistor datasheets in order to convert measured resistance to temperature.

Merge request reports

Checking pipeline status.

Approval is optional
Code Quality is loading

Closed by Fabio RaveraFabio Ravera 2 years ago (Feb 10, 2023 10:56pm UTC)

Merge details

  • The changes were not merged into Dev.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Hi Alessandro, I am not 100% sure what is it going on... @leejr can you help us? I think it may be related to the setting on the CI on Alseeandro's repo... does he need to be developer to be able and pull the tcusb repo? Also, for some reason I cannot restart the CI on this merge request... It looks like the pipeline is run on Alessandro's repo and not the cms_tk_ph2 one... It is not the first time I saw this, do you know what is the reason?

    • Yeah, for this MR workflow, that's intended (@enibigir can correct me if that's wrong). Devs submit MRs from their forks, and the CI is from their forks. Once it's merged, the pipeline will run on the central repo. Therefore, only the dev can restart those jobs.

      For this one -- is there a requested change for the tcusb? If so, you'd have to put the new commit hash into the setup.sh so that the CMake config in the CI knows what version to grab.

    • Oh I'm sorry. Now I see the problem. Looking into it. This happened before when the dep repo deleted a branch...

    • Ah I see it @fravera. @rossia -- You're not a member of cms_tk_ph2 so it means you don't have access rights to that repo. If you join that group, your account will have access to the repo and will be able to checkout that dependency!

    • You are right. That's the first thing people should do as mentioned in the README https://gitlab.cern.ch/cms_tk_ph2/Ph2_ACF#gitlab-ci-setup-for-developers-required-to-submit-merge-requests

    • Please register or sign in to reply
1 Subproject commit ad052418cf839f3668e9cdd7f9f6a8f2f2ce0e0e
1 Subproject commit f5f32f0d026cb8b48183a2b7176df66945bfbb03
  • Hi @rossia, do you have any updates on this PR?

  • Hi @fravera, sorry I completely forgot this. I guess the best thing will be rebase the PR on the latest branch (and follow completely the instructions for developers...). I will do in the next days.

  • closed

  • Please register or sign in to reply
    Loading