Skip to content

Render DAC scans plot for VFATs with failing DAC by default

Laurent Petre requested to merge feature/plot-dac-scans-on-warnings into main

Description

This MR allows plotting only VFAT with a failing DAC. The option -p/--plotting is modified to take any of {always, never, warning}

It was implemented in two steps:

  • Refactor the DAC scans routine to split the analysis from the plotting
  • Implement the conditional plotting option

Related Issue

Fixes #38 (closed).

How Has This Been Tested?

Tested on the 72 VFAT of the GE1/1 integration setup. The chosen DAC values did not change. The plotting option behaves as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports