Simplify XDAQ tabs
Summary
Currently the GEMWebApplication
creates a couple of default tabs, namely the monitor tab and the expert tab with the optional application tab. Looking at the currently xdaq applications, several of the apps don't have their expert or monitor tab filled with anything leading to unneeded information in the current setup. Also, the applicationPage
, while optional, is not defined so every class that inherits the WebApp has to define it, even if its a trivial empty function. This can be seen in the code where many child classes have empty page
functions that aren't used
What is the expected correct behavior?
To give more flexibility, I think the XXXPage
could be combined into a single function. Also, the creation of the xdaq tabs could be handled by the child class to allow for more freedom for naming and way the data is displayed. To allow minimal change in the code, a new virtual function, say fillPageContents
could be created that in the child classes could call expertPage
, applicationPage
, monitorPage
, etc.
Along with this change, it could allow the switch from xdaq-tab
to bootstraps nav
tabs as mentioned in !111 (closed)
If a more gentle approach is preferred, this branch was created to emulate the changes made in !39 (closed). This change only removed the monitoring tab to be replaced by the existing applicationPage
function. To me, this seems like a half measure and could be fixed better as outlined above.
Other ideas are welcome!