Skip to content

Move the AMC13 monitoring to the monitoring suite

Dylan Oliver Teague requested to merge feature/move-amc13-monitor into main

Description

This MR is to migrate the AMC13 monitoring into the fedmonitor to centralize all of the monitoring. This involves gutting most of the functions in AMC13ManagerWeb, mainly because AMC13ManagerWeb just grabs values from `AMC13Manager.

Related Issue

Closes #142 (closed), relates to #38 (closed).

How Has This Been Tested?

The way the AMC13 sends the monitor, it can either send it as a full HTML file (including the style element) or as just the HTML table. With the style included, it makes the tables look nice as in the Old Version, but it also messes up all of the css definitions. This makes using the bare HTML better, but the tables are not as compact with the bootstrap format. Because the table size and number can change with the status level, it makes it hard to put in a HTML solution to this problem easily.

If a solution is seen, I can implement it, but with the current version, I was able to make not satisfying fix

Old version

image

New version

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Dylan Oliver Teague

Merge request reports