Skip to content

Overhaul xDAQ tabs to Bootstrap nav-tabs

Dylan Oliver Teague requested to merge feature/xdaq-to-navtab-overhaul into develop

Description

As mentioned in MR !111 (closed), it would be nice to move xdaq tabs to bootstrap's navtabs. To do this, the structure of webDefault needs to be changed. The basic premise to to have each web based class set what the tabs it will needs in its constructor and webDefault sets up the HTML code needed to make the tabs. This removes the need for default webPage functions such as monitorPage because each class can just make the pages it needs.

This change does require a large change to the existing code base because references to the old monitorPage, expertPage, and applicationPage must be removed from all the web based classes

MR !111 (closed) is kept separate for the moment simply because it can be merged most quicker (much less is changed) and it resolved more clearly the problem posed in issue #95 (closed), ie the xdaq tabs not changing correctly because of an indexing issue. If wanted, !111 (closed) can be added to this MR to keep the change in a single MR.

Related Issue

Closes #95 (closed)

How Has This Been Tested?

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports