Skip to content

Generalize GBT phases using GBT and elink numbers

Description

Generalizes the writeGBTPhase function to use GBT and elink as parameters instead of VFAT number. The GBT phase scan function is adjusted accordingly and the output format of the GBT phase scan contains now the gbt and elink columns instead of the vfat column.

To be implemented:

  • Improve log message when invalid phase is set
  • Move default phase map from gemhardware to gemcore
  • Update cmsgemos-analysis to analyze GBT phase scan result with new format (see MR 24 in the analysis repository)
  • Use updated configuration file format in cmsgemos

Related Issue

How Has This Been Tested?

Tested on GE2/1 integration stand in B904.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Antonello Pellecchia

Merge request reports