Skip to content

Put OH information into monitorable table as a popover

Dylan Oliver Teague requested to merge feature/chamberID-in-montable into main

Description

As the title suggests, this MR puts useful information about a specific OH in the monitoring suite in a popover for the OH table headings. Specifically it puts the display name and UID as information in the table

Possible points of change

  • Current the xgi code is the AMCMonitor not AMCMonitorWeb class for convenience, but if the separation between the classes is wanted to be enforced, this can be accommodated
  • More information may be wanted to be included in the popover, discussion on this may be fruitful
  • Related to the previous point, the info in the popover is the best interpretation of the writer thus some of this may be incorrect

Related Issue

Closes #198 (closed)

Screenshots

image Example of what the popover currently looks like

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports