Skip to content

Fix data taking with the CTP7

Laurent Petre requested to merge bugfix/enable-ttc-cmd into main

Description

After the merge of !268 (merged), it was noticed that data taking was impossible with the CTP7. Indeed, the TTC B-channel (i.e. commands) was disabled after the AMC register reset. This MR aims at restoring the correct behavior in case the TTC generator is not enabled.

It was also noticed that the TTC phase monitoring target value was reset. Preserve this value during the AMC reset.

Finally, this MR includes a fix for #216 (closed). It was deemed to be the right moment to do so since the "TTC MMCM reset" is only aligning the TTC clock phase. Would a real TTC MMCM be implemented in the future, the ordering would already be correct and debugging, if needed, could take place at that moment.

Related Issue

Fixes #216 (closed).

How Has This Been Tested?

Trivial change, but cannot be tested on hardware. 😕

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports