Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • CTA CTA
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 147
    • Issues 147
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ctacta
  • CTACTA
  • Issues
  • #223
Closed
Open
Issue created Nov 24, 2022 by Lasse Tjernaes Wardenaer@lwardenaOwner

Fix "hostName.empty()" bug and remove vid check

When going from C style to C++ style environment variable handeling, we must change some of the existence checks. In cta-verify-file the program will throw an error if HOSTNAME is not defined, as the empty() function checks if a string is equal to ""(c-style), but not nullptr. By removing the vid check, this bug is resolved.

In addition, the vid check should be removed, as it increased the run time when calling the tool with a single id. Run time will increase n^2 if a list of ids is not provided, but other tools do not use it efficiently. Therefore, a better solution to confirm that a vid exists must be found. This will be addressed in another issue. See the issue here #224 (closed)

Edited Nov 24, 2022 by Lasse Tjernaes Wardenaer
Assignee
Assign to
Time tracking