[#92] Add SSO proxy

changed title from [#wip] Add SSO proxy to [wip] [#92] Add SSO proxy

added 1 commit

• c9f661b9 - Missing flag on SSO Proxy

Compare with previous version

added 1 commit

• 240ffdcd - First working prototype of SSO proxy

Compare with previous version

requested review from @crdeoliv, @jlopesda, and @vasvi

added 11 commits

• 240ffdcd...524d78f9 - 10 commits from branch master
• 894ca91c - First working prototype of SSO proxy

Compare with previous version

added 1 commit

• 3c83ca9f - First working prototype of SSO proxy

Compare with previous version

Why does the case "sso-proxy" exist twice in this switch statement?

Can you show the second switch case statement?

I know I wasn't asked for a review, nevertheless some comments from my side before this gets pushed out.

changed title from [wip] [#92 (closed)] Add SSO proxy to [#92 (closed)] Add SSO proxy

added 1 commit

• 5655dd11 - Added new comments and changed code based on review

Compare with previous version

Thanks a lot for the input @jhensche !

Given this comment, are you sure you want to add new code here?

Due to the fact we are not migrating anything at this point in time, I prefer to add to the current expected model for lower possible negative impact.

For a little less code repetition I'd replace with

	serverName := "nginx"
	serverPort := 8080
	if d.Labels[ssoProxyLabel] == "true" {
		serverName = "sso-proxy"
		serverPort = ssoProxyPort
	}
	currentobject.Spec.Ports = []corev1.ServicePort{
		{
			TargetPort: intstr.FromInt(serverPort),
			Name:       serverName,
			Port:       80,
			Protocol:   "TCP",
		},
		{
			TargetPort: intstr.FromInt(9253),
			Name:       "php-fpm-exporter",
			Port:       9253,
			Protocol:   "TCP",
		}}

Also consider moving "sso-proxy" to a variable.

changed this line in version 7 of the diff

sso-proxy was done to keep the same styling as other containers, although I agree.

The refactor has been done