The multiple stream manager was adding configured ByteStream output
streams in the old Gaudi style to "theApp". In multithreaded transforms
this means they no longer appear in the AthOutSeq, and thus no output is
written. This commit fixes that.

Don't use post-increment with user iterators.

Two new methods in the `IGeoModelSvc` interface:

1. `getParamSvcName()` returns the name of the Service which implements the `IRDBAccessSvc`
interface and which is used in the current job. This method allows us to avoid hardwiring the
name of the `IRDBAccessSvc` retrieved by the clients.
2. `buildFromSQLite()` to be used by `GeoModel` tools to determine whether or not the geometry
is being constructed from the SQLite file, and act accordingly.

Changes in the `GeoModelSvc`:

1. Introduced new property `SQLiteDB` which allows us to pass the path to the SQLite database file.
If the property is set, then the geometry is built from that SQLite file. Otherwise the geometry
is built from the Geometry Database tags.
2. Added a first implementation of the mechanism of building GeoModel description from the SQLite
database. This mechanism is not yet complete, but it can already be used for testing purposes.

Also fixed `SqliteRecord::dump()` so that it properly handles NULL values in table records.

The new Athena Service has been introduced to allow reading detector description
parameters from plain SQLite tables, which are collocated in the same SQLite
database together with the persistent representation of the GeoModel description
tree.

In order to allow for smooth transition of clients from the RDBAccessSvc to
the new SqliteReadSvc, the latter implements the IRDBAccessSvc interface.

The functionality that is yet to be implemented: an analogue of the RDBQuery for
reading data from SQLite tables.

Use WithRootErrorHandler to change the root error handler, for better
thread-safety.

See ATEAM-715.

Need to include TIterpreter.h to suppress spurious ubsan warnings.

Need to explicitly link tests against root libraries to suppress ubsan
warnings.

Missing override keywords.

Marcin Nowak authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

IOVSvc is requesting reading of its IOV Conditions objects into a
dedicated PersistencySvc instance (context), so all conditions files can
be closed by simply deleting this instance. This was up to now ignored
by PoolSvc/ConversionSvc (by mistake). Here I am fixing this mistake and
adding context-awarness to 2 converters that read objects containing
POOL Refs to other object (DataHeaderCnv and CoolMultChanCnv).
I also add EndProcessing incident trigger to IOVDbSvc because in
AthenaMT the StoreCleared incident is not fired (this is to trigger
Condition files closing after the first Event)

Use DBLock to serialize access to the underlying database code
with respect to other Athena packages.

Use DBLock to serialize access to the underlying database code
with respect to other Athena packages.

Athena has multiple packages that access the database independently,
for example IOVDbSvc (via COOL) and RDBAccessSvc.  These are all locked
internally, but they don't know about each other.  Further, some of
the underlying database code which they can both use, such as frontier,
is not thread-safe.  Thus, we can get crashes if, say, IOVDbSvc and
RDBAccessSvc are executing in different threads.

To solve this without introducing a depedency between these packages,
we introduce this package containing only this lock class.  Any Athena
package that needs exclusive access to the database layer can then
acquire the lock here.

The DBLock object copyable; it holds the underlying lock
via a shared_ptr.  Further, the underlying mutex is recursive.

This is attempting to address issues such as ATLASRECTS-5582.

Same fix as !41031 but in SharedWriter now

Fix cppcheck warnings.

Fix cppcheck warnings.

Pass class objects by const reference, not by value.
Prefer initializing class members in an initialization list.
Fix misplaced parenthesis.

zlib.crc32 takes a bytes object, not a string.

Move file closing funcionality that was earlier in IOVDbSvc::handle()
and was triggered by StoreCleaned incident to a new method:
IOVDbSvc::postConditionsLoad()
Make CondInputLoader call it after loading all conditions.
File closing releases TTreeCache memory (30MB * 3)

Currently setting properties is case-insensitive. This will change with
Gaudi v36 and in general one should really check if setting a property
succeeded or not.