Version 7 of the FT decoding

Works with lhcb/LHCb!2942 (merged)

Reformulates the link<->SiPM correspondency in the FT. Not backwards-compatible, but adds a versioning for the ReadoutTool to send proper ERROR in case of mismatch.

mentioned in merge request lhcb/LHCb!2942 (merged)

added 1 commit

• 56503a4a - Added a version parameter

Compare with previous version

added 1 commit

• 9dfe6a47 - Update ReadoutMap.xml

Compare with previous version

@lohenry : what is the status of this MR? It is still in WIP? or can it be reviewed for future merge?

cc: @gcavalle

It is related to lhcb/LHCb!2942 (merged). That being said, it can be reviewed as it should not change much.

if this MR is for the FT, then why does it add Rich1, Rich2, UT, VP, VeloLite xml entries?

and can it be re-based on top of the current master? and perhaps some commits can be collapsed?

changed target branch from master to upgrade/master

marked this merge request as ready

mentioned in merge request !153 (closed)

changed the description

resolved all threads

changed the description

@gcorti This MR and the associated LHCb MR (lhcb/LHCB!2942) are ready to be tested as far as we are concerned. Should I just approve or is there something else to do?

assigned to @lohenry

It should not be merged before testing. For the test we have been discussing with @clemenci how to do it but for now you can force in the test the use of this branch by giving it as a 'tag'.

mentioned in issue lhcb/Moore#324 (closed)

mentioned in issue lhcb/Moore#335 (closed)

We discussed this MR at the last PAC with @cattanem and @rmatev.

This normally would be merged on top of the changes of the Muons that cause problems if the corresponding code in LHCb is not picked up.

I see that you started from quite a while ago, so in order to be able to use this without the Muon changes but all other changes that have been introduced we need to make a branch from the last tag without the Muon and then merge this. If then all tests with that and lhcb/LHCb!2942 (merged) are ok, we can also put this on master...

@gcavalle, @lohenry do you agree with this? If yes I will prepare the branch and change the target of this MR to the new branch that can be used directly and from which we can make a new MR targeting master

FYI @seaso

changed target branch from upgrade/master to upgrade-sim-20211006-vc-md100-ft-v7

resolved all threads

Merging to new branch.

mentioned in commit 143044c4

merged

Hi @lohenry,

can you try to use upgrade-sim-20211006-vc-md100-ft-v7 with the HEAD of LHCb and Boole?

And if all is fine, please make a MR from upgrade-sim-20211006-vc-md100-ft-v7 to master, so that it is attributed to you