[RTA/DPA BW tests]: Temporarily allow error code 1 for process = hlt2 in bw tests

FYI @lugrazet

Goes with lhcb/Moore!3644 (merged), lhcb-datapkg/PRConfig!433 (merged) and LHCbNightlyConf!1254 (merged)

When we move the tests to real data in the above MRs we'll get ERROR messages due to Misordered Large Clusters that we can't do anything about, but they aren't harmful. We ignore them in the Moore qmtest, but they'll give an error code of 1, so we have to ignore them here to make sure the bandwidth tests give "success" messages even if they hit this.

Testing fine for me locally.

handlers/BandwidthTestHandler.py

@@ -341,8 +341,13 @@ def send_gitlab_feedback(n_new_lines, tot_rate_new, tot_rate_ref,
 
     rate_comp_str = safe_comp_str(tot_rate_new, tot_rate_ref, "kHz")
     bw_comp_str = safe_comp_str(tot_bandwidth_new, tot_bandwidth_ref, "GB/s")
-    status_msg = GOOD_TEST_MSG if single_test_info[
-        'code'] == 0 else BAD_TEST_MSG
+    if single_test_info['code'] == 0:
+        status_msg = GOOD_TEST_MSG
+    elif single_test_info['code'] == 1 and process == "hlt2":
+        # Temporarily allow this status code due to "Misodered large cluster" errors in data we can't get rid of
+        status_msg = GOOD_TEST_MSG
+    else:
+        status_msg = BAD_TEST_MSG
     status_msg = status_msg.replace(
         ":bluetick:",
         ":ballot_box_with_check:")  # `bluetick` not supported on GitLab
@@ -383,13 +388,20 @@ def send_mattermost_feedback(options, version, web_link, process,
             tot_bandwidth: total bandwidth from test
     """
     pfx = f"{process.upper()} ({stream_config})"
+    if single_test_info['code'] == 0:
+        test_msg = GOOD_TEST_MSG
+    elif single_test_info['code'] == 1 and process == "hlt2":
+        # Temporarily allow this status code due to "Misodered large cluster" errors in data we can't get rid of
+        test_msg = GOOD_TEST_MSG
+    else:
+        test_msg = BAD_TEST_MSG
     message = (
         "The results of latest bandwidth test "
         f"[{options} {version}]({web_link}):\n"
         f"`{pfx} Total rate = {single_test_info['total_rate']:.1f} kHz`. `{pfx} Total bandwidth = {single_test_info['total_bandwidth']:.1f} GB/s`.\n"
         f"{pfx} Lines with rate of 0 Hz: {single_test_info['n_low_rate']}. "
         f"{pfx} Lines with rate > {rate_tolerance(process)} Hz: {single_test_info['n_high_rate']}.\n"
-    ) + (GOOD_TEST_MSG if single_test_info['code'] == 0 else BAD_TEST_MSG)
+    ) + test_msg
     log.info(f"Posting Mattermost feedback:\n message={message}")
     publish.post_mattermost(message)
 
@@ -652,6 +664,11 @@ class BandwidthTestHandler(BaseHandler):
             if hlt2_test_info['code'] == 0:
                 log.info("Copying hlt2 outputs to eos.")
                 copy_hlt2_outputs_to_eos(directory)
+            elif hlt2_test_info['code'] == 1:
+                log.info(
+                    "Error code 1 on the HLT2 test - we temporarily allow this code. Copying hlt2 outputs to eos."
+                )
+                copy_hlt2_outputs_to_eos(directory)
             else:
                 log.info("Not copying test outputs to eos as test failed.")