Skip to content

Fix hardcoded geometry in forward/seeding algorithms

Fixing the geometry hardcoding in forward/seeding algorithms: #463 (closed)

Changing DumpFTGeometry to dump in the .bin geometry files also the info of the average z and average dxdy per layer.

Through Moore, dumped the geometry in scifi_geometry.bin.

./Moore/run gaudirun.py Moore/Hlt/Moore/tests/options/default_input_and_conds_hlt1_retinacluster.py Allen/Dumpers/BinaryDumpers/options/dump_geometry.py

The Consumers at the beginning of the Allen sequence take these constants from the geometry and store it in the GPU. The constants are accessible in each Allen kernel using constants.dev_scifi_geometry in the operator.

Implemented new versioning of scifi geometry for retro-compatibility:

  • v0 hardcoded - v2 read-in geometry: for scifi decoding v4,5,6
  • v1 hardcoded - v3 read in geometry: for scifi decoding v7,8

All new dumped geometries will be either v2 or v3 depending on the decoding. If Allen reads a geometry v0 or v1 then hardcoded scifi geometry values are used (retro-compatibility)

Testing the effect of going for layer-level to scifi quarter-level geometry constants on a second MR to factorise the work: #497

@dovombru @gligorov @lcalefic

Edited by Alessandro Scarabotto

Merge request reports