Draft: Add momentum- and position-based pseudorapidity calculations to CompositeParticle
The CompositeParticle
eta
calculation uses the secondary vertex and PV positions to calculate pseudorapidity. This choice was not clear to users and doesn't give sensible results for non-displaced vertices. It could also provide worse resolution than a momentum based calculation for fully reconstructed particles.
This MR:
- Removes the
CompositeParticle::eta
- Adds
CompositeParticle::eta_position
andCompositeParticle::eta_momentum
- Replaces
eta
witheta_position
andeta_momentum
in all selections. Unless the line authors' intentions were clear, I usedeta_position
for lines selecting partially reconstructed decays andeta_momentum
for lines selecting fully reconstructed decays.
FYI @gligorov