Draft: Add momentum- and position-based pseudorapidity calculations to CompositeParticle
The CompositeParticle eta calculation uses the secondary vertex and PV positions to calculate pseudorapidity. This choice was not clear to users and doesn't give sensible results for non-displaced vertices. It could also provide worse resolution than a momentum based calculation for fully reconstructed particles.
This MR:
- Removes the
CompositeParticle::eta - Adds
CompositeParticle::eta_positionandCompositeParticle::eta_momentum - Replaces
etawitheta_positionandeta_momentumin all selections. Unless the line authors' intentions were clear, I usedeta_positionfor lines selecting partially reconstructed decays andeta_momentumfor lines selecting fully reconstructed decays.
FYI @gligorov