Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Allen Allen
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 177
    • Issues 177
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 78
    • Merge requests 78
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • AllenAllen
  • Merge requests
  • !948

Redefine the global event cut to not use UT information

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vladimir Gligorov requested to merge gligorov_remove_ut_from_gec into master Jul 29, 2022
  • Overview 45
  • Commits 15
  • Pipelines 13
  • Changes 82

This removes the use of UT information from the global event cut. The default cut value is not changed which as a byproduct means that the GEC in Allen will become more of a "sanity" cut removing only the really few very highest occupancy events, which probably goes in the direction we want to go long-term anyway ( @mvesteri @decianm ). This will be a mess of reference updates and I may well have forgotten something but otherwise is ready for review @dovombru @dcampora @raaij

With this MR, the following slowdown is observed due to loosening the GEC:

Device                        Throughput (kHz)    Reference Throughput (kHz)  Speedup    % change    Status
--------------------------  ------------------  ----------------------------  ---------  ----------  ---------
NVIDIA RTX A5000                        136.13                        149.7   0.91x      -9.07%      DECREASED
AMD EPYC 7502 32-Core                    16.72                         17.27  0.97x      -3.20%      OK
NVIDIA GeForce RTX 2080 Ti              110.87                        120.8   0.92x      -8.22%      DECREASED
NVIDIA GeForce RTX 3090                 176.63                        194.07  0.91x      -8.98%      DECREASED
Device-averaged speedup: 0.93x
               % change: -7.37%
                 status: DECREASED
Edited Aug 22, 2022 by Daniel Hugo Campora Perez
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gligorov_remove_ut_from_gec