Remove various unused tupletools from Phys/DecayTreeTupleReco

Try to do !802 (closed) but piecewise - a full removal of all tuple tools in one go is effectively impossible. Follows from recent discussions around the clean-up of superseded code and tools and the retirement of the Phys project. See also !802 (comment 4771563).

Addresses part of lhcb-dpa/project#7 via https://gitlab.cern.ch/lhcb-dpa/project/-/issues/159.

This MR does parts of !828 (merged) so may become obsolete.

added DPA-WP3 Tuples cleanup labels

assigned to @pkoppenb

Hey @pkoppenb, this is also ready, meaning I believe the remaining tools in Phys/DecayTreeTupleReco are still in use by RTA. So happy to trigger a CI test if you're happy too.

changed the description

/ci-test --merge

Started reference and integration test builds. Once done, check the comparison of build and test results.

Throughput Test Moore_hlt2_reco_baseline: 154.9 Events/s -- change of -0.19% vs. reference

Throughput Test Moore_hlt2_fastest_reco: 385.8 Events/s -- change of 0.25% vs. reference

Throughput Test Moore_hlt1_pp_default: 27301.1 Events/s -- change of 0.04% vs. reference

added ci-test-triggered label

• [2021-10-06 11:55] Validation started with lhcb-master-mr#2997
• [2021-10-08 00:10] Validation started with lhcb-run3-cleanup#332
• [2021-10-10 11:16] Validation started with lhcb-run3-cleanup#334
• [2021-10-11 00:55] Validation started with lhcb-run3-cleanup#335
• [2021-10-12 01:06] Validation started with lhcb-run3-cleanup#336
• [2021-10-13 00:46] Validation started with lhcb-run3-cleanup#337
• [2021-10-14 00:54] Validation started with lhcb-run3-cleanup#338
• [2021-10-15 00:31] Validation started with lhcb-run3-cleanup#339
• [2021-10-16 00:51] Validation started with lhcb-run3-cleanup#340

added lhcb-run3-cleanup label

marked this merge request as draft

marked this merge request as ready

changed the description

Hey Patrick, I see your comment above that "This MR does parts of !828 (merged) so may become obsolete." I'm not sure that is the best approach, TBH. What I have been trying to do is to get rid of what is not used to then be able to move to MooreAnalysis only what is needed by the project, and nothing else. Fingers crossed that your bigger MR works, but otherwise we may have to go in several steps. Let's see the results of the nightlies tomorrow ...

Yes, bottom up versus top-down approaches. I started from lhcb-run3-cleanup where all your MR are in, except this one. Then I realised they may interfere. I should have merged this first before starting. What I want to avoid is that my MR can no longer be merged until rebase. I hope git is smart enough, but don't want to take risks for tonight's nightlies. Let's see.

removed lhcb-run3-cleanup label

Removing lhcb-run3-cleanup as it is causing merge conflicts with !828 (merged)

This MR got superseded by !828 (merged). Closing.

closed