Skip to content

Added pixel smearing in VP to match 2023 data taking values

David Hutchcroft requested to merge dhcroft-VPPixelCrosstalk into master

These changes are to increase the VP pixel smearing to better match the data from 2023. There is 5% pixel to pixel cross-talk (cardinal directions only) and 1.5 times the old charge diffusion pattern, both tuned for 250V simulated HV, as that scales the diffusion. See https://indico.cern.ch/event/1378233/contributions/5803373/attachments/2801722/4890059/VPSimUpdateFeb2024.pdf for more details.

Important caveats:

  • This MR works with USE_DD4HEP OFF as is, but with USE_DD4HEP ON combined with Detector!544 (merged)
  • The boole tests currently turned off in Digi/Boole/CMakeLists.txt if USE_DD4HEP is defined can be re-enabled
  • There is a warning due to changing [=] to [=, this] in the lambda function, which is a C++20 adaption, see MR 6d060460 from @sponce. That can be reversed if required (both formulations work, they just give warnings in the "wrong" c++ version).

This needs the update to VPDigitAssociator to avoid changing the MC to VP cluster association Lbcom!723

Edited by David Hutchcroft

Merge request reports