Skip to content

Added a muon_debug.xml, added the muon to LHCb.xml and various cleanups

Ben Couturier requested to merge bcouturi_Muon into scali_Muon

I added a muon_debug.xml file and an associated test. I also added the muon to LHCb.xml

Tasks still to be done:

  • refactor the Muon_debug and muon_system.xml to keep the common parts and make reuse easier
  • cleanup the includes (we should not be importing .cpp files)
  • Some warning at compilation are worrying (c.f. below)
41/102] Building CXX object CMakeFiles/DetectorLib.dir/Detector/Muon/src/muon_geo_stations.cpp.o

../Detector/Muon/src/muon_geo_stations.cpp: In function ‘dd4hep::Ref_t BuildMuonSystem(dd4hep::Detector&, xml_h, dd4hep::SensitiveDetector)’:

../Detector/Muon/src/muon_geo_stations.cpp:622:46: warning: ‘BeamPipeBigRad’ may be used uninitialized in this function [-Wmaybe-uninitialized]

  622 |                      BeamPipeBigRad + offset );

      |                                              ^

../Detector/Muon/src/muon_geo_stations.cpp:622:46: warning: ‘BeamPipeSmallRad’ may be used uninitialized in this function [-Wmaybe-uninitialized]

../Detector/Muon/src/muon_geo_stations.cpp:622:46: warning: ‘BeamPipeLenght’ may be used uninitialized in this function [-Wmaybe-uninitialized]

../Detector/Muon/src/muon_geo_stations.cpp:620:69: warning: ‘BoxSizeZ’ may be used uninitialized in this function [-Wmaybe-uninitialized]

  620 |   Box              Box( BoxSizeX / 2., BoxSizeY / 2., BoxSizeZ / 2. );

      |                                                                     ^

../Detector/Muon/src/muon_geo_stations.cpp:620:69: warning: ‘BoxSizeY’ may be used uninitialized in this function [-Wmaybe-uninitialized]

../Detector/Muon/src/muon_geo_stations.cpp:620:69: warning: ‘BoxSizeX’ may be used uninitialized in this function [-Wmaybe-uninitialized]

[95/102] Building CXX object CMakeFiles/DetectorLib.dir/Detector/Muon/src/muon_geo_filters.cpp.o

../Detector/Muon/src/muon_geo_filters.cpp: In function ‘dd4hep::Ref_t BuildFilters(dd4hep::Detector&, xml_h, dd4hep::SensitiveDetector)’:

../Detector/Muon/src/muon_geo_filters.cpp:53:10: warning: variable ‘MF_RotZ’ set but not used [-Wunused-but-set-variable]

   53 |   bool   MF_RotZ = false;

      |          ^~~~~~~

../Detector/Muon/src/muon_geo_filters.cpp:305:88: warning: ‘InnBoxSizeZ’ may be used uninitialized in this function [-Wmaybe-uninitialized]

  305 |       Box              inner_box( InnBoxSizeX / 2., InnBoxSizeY / 2., InnBoxSizeZ / 2. );

      |                                                                                        ^

../Detector/Muon/src/muon_geo_filters.cpp:305:88: warning: ‘InnBoxSizeY’ may be used uninitialized in this function [-Wmaybe-uninitialized]

../Detector/Muon/src/muon_geo_filters.cpp:305:88: warning: ‘InnBoxSizeX’ may be used uninitialized in this function [-Wmaybe-uninitialized]

../Detector/Muon/src/muon_geo_filters.cpp:304:88: warning: ‘OutBoxSizeZ’ may be used uninitialized in this function [-Wmaybe-uninitialized]

  304 |       Box              outer_box( OutBoxSizeX / 2., OutBoxSizeY / 2., OutBoxSizeZ / 2. );

      |                                                                                        ^

../Detector/Muon/src/muon_geo_filters.cpp:304:88: warning: ‘OutBoxSizeY’ may be used uninitialized in this function [-Wmaybe-uninitialized]

../Detector/Muon/src/muon_geo_filters.cpp:304:88: warning: ‘OutBoxSizeX’ may be used uninitialized in this function [-Wmaybe-uninitialized]

[102/102] Linking CXX shared module lib/libDetectorPlugins.so

Merge request reports