Skip to content

Refactor Pipe

Emir Muhammad requested to merge emmuhamm_add_T into refactor_compact_rebased

This merge requests does a couple of things

  • Add the T stations, which was missing from the previous merge request
  • Breaks apart the Pipes to you can include pipes on specific sections.

Some notes on current implementation:

  • Some pipes are currently dependent on PipeAfterMagnet. It's because PipeAfterMagnet calls in Pipe/AfterMagnet-Params, which PipeT, PipeAfterT, and PipeDownstream need. This bit hasn't been refactored yet, any suggestions welcome.

  • PipeVP and PipeUT are dependent on the subdetectors VP and UT respectively; this is because those two pipes are attached to the VP and UT regions, which aren't created until those two subdetectors are added in. Could be fixed by modifying Regions/detector.xml, but might be best to leave it for later as this brings a discussion of how we would like to refactor the regions themselves as well.

TODO:

  • Understand VMA imports (for later)
Edited by Emir Muhammad

Merge request reports