Skip to content

Change FT geometry for MP

Gary Robertson requested to merge MP-changeFT-assembly into master

Motivation: updates the FT geometry to match what is needed for the MP geometry, works with Gauss!1074 (merged)

Code Change:

  • Changing the lv of FT to be an Assembly instead of a Volume.
  • Create an override of DeFT::isInside to avoid segfault, e.g. in GetTrackerHitsAlgBase::fillHit. @tlatham . Because if calling DeFT::isInside then it will currently call the base class method and result in a segfault, while this override will restore the proper behaviour. So this change must therefore go in at the same time as lvFT being changed to an assembly.
  • Update the checksum for all version including the released version. FT_Check.pdf summarizes the effects of this merge request and Gauss!1074 (merged) on FT. It appears that the fluctuations mostly occur in low-statistics areas. Additionally, if we examine the number of entries in the 2D histograms, they differ by 1-1.5% over 1000 events. Considering that the random numbers evolve differently, the results are inconclusive. And the Scifi group (@zehua and @lohenry) has confirmed that these changes are acceptable to them.

Validated by

  • Core Software
  • RTA
  • Simulation
Edited by Gloria Corti

Merge request reports

Loading