Remove last usages of GaudiHistoAlg
Full list of places where it is still used (as of Dec 2nd 2024) :
LHCb
- https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/CaloFuture/CaloFutureUtils/include/CaloFutureUtils/CaloFuture2Dview.h
- https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/GaudiAlg/dict/dictionary.h
- https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Phys/LoKiCore/src/HistoBook.cpp
- https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Rich/RichFutureKernel/include/RichFutureKernel/RichHistoAlgBase.h
- https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Rich/RichKernel/include/RichKernel/RichHistoAlgBase.h
Lbcom
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/DAQ/DAQMonitors/src/RawBankReadoutStatusMonitor.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/DAQ/DAQMonitors/src/RawBankSizeMonitor.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/DAQ/DAQMonitors/src/TriggerTypeCounter.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/MCUTDepositMonitor.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/MCUTDigitMonitor.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTClusterChecker.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTClusterClassification.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTClusterResolution.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTDigitMonitor.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTLandauTest.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTOccupancy.h
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTPerformanceMonitor.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTMonitors/src/UTLiteClusterMonitor.cpp
- https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/VP/VPMonitors/src/VPHitMonitors.cpp
Rec
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/CaloFuture/CaloFutureMoniDst/src/CaloFutureMoniAlg.h
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Phys/ParticleMaker/src/ParticleMassDTFMonitor.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Pr/PrMCTools/src/VPClusterEfficiency.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Rec/RecAlgs/src/EventTimeMonitor.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Rec/RecAlgs/src/ProcStatAbortMoni.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Rec/RecAlgs/src/RecProcessingTimeMoni.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Tr/TrackCheckers/src/TrackCheckerBase.h
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Tr/TrackMonitors/src/TrackDiMuonMonitor.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Tr/TrackMonitors/src/TrackMonitorBase.h
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Tr/TrackMonitors/src/TrackMuonMatchMonitor.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Tr/TrackMonitors/src/TrackV0Monitor.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Tr/TrackUtils/src/TrackBestTrackCreator.cpp
- https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Tr/TrackUtils/src/TrackCloneKiller.cpp:
Boole
- https://gitlab.cern.ch/lhcb/Boole/-/blob/master/Calo/CaloDigit/src/CaloDigitAlg.cpp
- https://gitlab.cern.ch/lhcb/Boole/-/blob/master/Calo/CaloMoniDigi/src/CaloDigitChecker.h
- https://gitlab.cern.ch/lhcb/Boole/-/blob/master/FT/FTDigitisation/src/FTClusterMonitor.cpp
- https://gitlab.cern.ch/lhcb/Boole/-/blob/master/FT/FTDigitisation/src/FTLiteClusterMonitor.cpp
- https://gitlab.cern.ch/lhcb/Boole/-/blob/master/FT/FTDigitisation/src/MCFTDepositMonitor.cpp
- https://gitlab.cern.ch/lhcb/Boole/-/blob/master/FT/FTDigitisation/src/MCFTDigitMonitor.cpp
- https://gitlab.cern.ch/lhcb/Boole/-/blob/master/FT/FTDigitisation/src/MCFTPhotonMonitor.cpp
Gauss
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Calo/CaloMoniSim/src/CaloMonitor.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/BremVeloCheck.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/CheckLifeTime.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/DecayAnalysis.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/GenMonitorAlg.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/GeneratorAnalysis.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/MCTruthMonitor.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/ProductionAnalysis.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussMonitor/src/ProductionAsymmetry.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussTools/src/Components/GaussTargetMultiplicity.cpp
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/GaussTools/src/Components/GaussTargetMultiplicity.h
- https://gitlab.cern.ch/lhcb/Gauss/-/blob/master/Sim/LbLamarr/src/LamarrHist.h
PS : command used to create this list :
git grep HistoAlg.h | grep -v release.notes | grep -v \\\.tex | grep -v GaudiAlg/include | grep -v GaudiAlg/src | grep HistoAlgActivity
@graven @jonrob after a bit of cleanup of the easy cases in Lbcom!777 (merged) and Rec!4168 (merged), here is the remaining usage of GaudiHistoAlg. All these files are calling non thread safe methods of it. I've started to contact the code owners to try to move forward
Resolved by Sebastien Ponce@sponce Thanks for this. Quick comment though but the links you have created above are not correct, they lead to 404 pages. They need to look more like
https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/Rich/RichFutureKernel/include/RichFutureKernel/RichHistoAlgBase.hi.e. you are missing the
-/blob/master/part.Edited by Christopher Rob Jones
- Resolved by Sebastien Ponce
For the RICH, I have MRs ready to go once master has migrated to Gaudi v39r1(+). !4676 (merged) !4719 (merged) !4753 (merged)
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/DAQ/DAQMonitors/src/TriggerTypeCounter.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/DAQ/DAQMonitors/src/RawBankReadoutStatusMonitor.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/VP/VPMonitors/src/VPHitMonitors.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTClusterChecker.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTClusterResolution.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTClusterClassification.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTLandauTest.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTOccupancy.h as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTCheckers/src/UTPerformanceMonitor.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/UT/UTMonitors/src/UTLiteClusterMonitor.cpp as completed
marked the checklist item https://gitlab.cern.ch/lhcb/LHCb/-/blob/master/CaloFuture/CaloFutureUtils/include/CaloFutureUtils/CaloFuture2Dview.h as completed
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/DAQ/DAQMonitors/src/RawBankReadoutStatusMonitor.cpp as incomplete
marked the checklist item https://gitlab.cern.ch/lhcb/Lbcom/-/blob/master/DAQ/DAQMonitors/src/TriggerTypeCounter.cpp as incomplete