Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 198
    • Issues 198
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 50
    • Merge requests 50
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !291

Modernize CaloInterfaces, CaloDAQ, CaloUtils

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge modernize-calo into master Sep 28, 2016
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 94
  • prefer std::make_unique over raw pointer + explicit delete
  • prefer constexpr functions
  • remove execute bit from source files
  • prefer range-based for loops
  • remove explicit destructors when the implicitly generated one will do the same
  • avoid comparing pointers to 0 (which is an int)
  • add const
  • prefer STL algorithms over raw loops
  • prefer to initialize variables when they are declared
  • prefer override over final
  • add final to classes when possible
  • prefer pass-by-const-reference over pass-by-const-pointer if passing a nullptr is a guaranteed SEGV
  • prefer auto
  • make CaloInterfaces headers only
  • prefer DeclareInterfaceID
  • prefer struct when a class has only public member functions/data
  • remove use of deprecated std::unary_function / std::binary_function
  • prefer extend_interfaces over explicit virtual inheritance
  • do not repeat pure virtual declarations
  • remove obsolete CVS and SVN keywords
  • remove unused CaloUtil.h

needs Rec!231 (merged), Phys!29 (merged), Analysis!40 (merged)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: modernize-calo