Skip to content

Modernize CaloInterfaces, CaloDAQ, CaloUtils

Gerhard Raven requested to merge modernize-calo into master
  • prefer std::make_unique over raw pointer + explicit delete
  • prefer constexpr functions
  • remove execute bit from source files
  • prefer range-based for loops
  • remove explicit destructors when the implicitly generated one will do the same
  • avoid comparing pointers to 0 (which is an int)
  • add const
  • prefer STL algorithms over raw loops
  • prefer to initialize variables when they are declared
  • prefer override over final
  • add final to classes when possible
  • prefer pass-by-const-reference over pass-by-const-pointer if passing a nullptr is a guaranteed SEGV
  • prefer auto
  • make CaloInterfaces headers only
  • prefer DeclareInterfaceID
  • prefer struct when a class has only public member functions/data
  • remove use of deprecated std::unary_function / std::binary_function
  • prefer extend_interfaces over explicit virtual inheritance
  • do not repeat pure virtual declarations
  • remove obsolete CVS and SVN keywords
  • remove unused CaloUtil.h

needs Rec!231 (merged), Phys!29 (merged), Analysis!40 (merged)

Merge request reports