Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 164
    • Issues 164
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 51
    • Merge requests 51
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCb
  • LHCb
  • Merge requests
  • !2931

Rewrite CMake configuration in "modern CMake"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Clemencic requested to merge cmake-modernization into master Feb 12, 2021
  • Overview 31
  • Commits 1
  • Pipelines 70
  • Changes 1000+

Rewrite of LHCb CMake configuration along the lines of gaudi/Gaudi!922 (closed) (and gaudi/Gaudi!986 (merged)).

The main changes are:

  • public headers moved into include directories
  • all external dependencies collected in the cmake/LHCbDependencies.cmake file
  • removed *Sys packages
  • cleaned up the internal dependencies (link only what is actually needed)

It requires

  • gaudi/Gaudi!1177 (merged)
  • lhcb-core/LbDevTools!167 (merged)
  • lhcb-core/LbNightlyTools!333 (merged)
  • Detector!73 (merged)
  • lhcb-core/LbDevTools!169 (merged)
  • lhcb-core/LbEnv!114 (merged)
  • lhcb-core/LbDevTools!171 (merged)

Downstream projects require a few backward compatible fixes due to a more strict configuration in LHCb:

  • Lbcom!544 (merged)
  • Online!481 (merged)
  • Rec!2410 (merged)
  • Phys!927 (merged)
  • Allen!566 (merged)
  • Alignment!180 (merged)
  • Panoptes!119 (merged)

Missing bits

  • custom environment(?)
  • refactoring
  • Detector/DD4hep support
  • move the remaining 2 local dependencies to the global deps file
Edited May 04, 2021 by Marco Clemencic
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cmake-modernization