Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 47
    • Merge requests 47
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3356

Improve unused sources detection and fix warnings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Clemencic requested to merge improve-unused-sources-detection into master Dec 07, 2021
  • Overview 18
  • Commits 6
  • Pipelines 5
  • Changes 15

!3334 (merged) introduced detection of unused subdirectories and source files but the DD4hep build relies (at the moment) on exclusion of subdirs and files to avoid building DetDesc specific code.

This MR introduces a mechanism to flag subdirectories as explicitly ignored (to be backported to run2-patches, !3357 (merged)) and fixes the warning about unused files (for source files the logic detects directories partially used but it's OK if all .cpp files in a directory are not used).

To be noted that TGeoTransportSvc was probably lost in the rebase of !2931 (merged) and required some intervention (f2ccd704) to actually compile.

I also fixed an issue with CMake < 3.19.

Closes #171 (closed)

Edited Dec 08, 2021 by Marco Clemencic
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: improve-unused-sources-detection