Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 43
    • Merge requests 43
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3404

Add constructor for ConditionAccessor that does not create a property

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Clemencic requested to merge allow-cond-accessor-without-property into master Feb 08, 2022
  • Overview 10
  • Commits 1
  • Pipelines 2
  • Changes 2

As @graven proposed in Moore!1301 (comment 5248825), it is useful to be able to create ConditionAccessors without associating them to a property (it's actually uncommon that we want to change a condition key at configuration time).

This MR adds a constructor for ConditionAccessor (both DetDesc and DD4hep variants) that does not imply a property. The two options will be:

struct MyAlg: ... {
  // condition with property
  ConditionAccessor m_cond1{this, "PropName", "Condition/Path/...", "my configurable condition"};
  // condition without property
  ConditionAccessor m_cond2{this, "Condition/Path/..."};
};

To-do:

  • modify the examples in FunctionalConditionAccessor.cpp to use the new constructor
Edited Feb 09, 2022 by Rosen Matev
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: allow-cond-accessor-without-property