Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Moore Moore
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 234
    • Issues 234
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • MooreMoore
  • Merge requests
  • !1301

Follow changes in Rec!2713

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Gerhard Raven requested to merge follow-rec-2713 into master Feb 04, 2022
  • Overview 18
  • Commits 4
  • Pipelines 10
  • Changes 4

Rec!2713 (merged) added a distinction between SDOCA and DOCA -- the former just uses the 'first' state to compute DOCA, and the latter uses the IDistanceCalculatorTool interface (with LoKi::DistanceCalculator as default - and only - implementation) which only works on LHCb::Particle.

In case an algorithm uses more than one DOCA cut, this leads to warnings about duplicate properties -- but as these properties will always have the same key and value, they are harmless -- and could be fixed by instantiating tool handles without corresponding property, but that would require extending the grammar for DOCA to be able to specify the tool instance instead.

Must be applied in conjunction with Rec!2713 (merged), LHCb!3404 (merged)

Edited Feb 09, 2022 by Gerhard Raven
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: follow-rec-2713