Skip to content

Drop FittedForward track type and use FitHistory instead

Andre Gunther requested to merge gunther-drop-fitted-forward into master

The track type FittedForward was introduced to account for the different set of states on a Long track fitted by the VeloKalman and PrKF, respectively. Conceptually, however, this is not a new track type because it also only has VP,UT and FT hits and is thus simply a Long track. This MR drops the FittedForward type and introduces a flag for FitHistory which is the correct distinction between the two flavours of Long tracks.

The reason to care is a different one though. Apparently, making usage of the FittedForward type obvious in other parts of the code (Rec!3677 (merged)) leads to change of ordering of tracks depending on the platform and thus to failing tests (credit goess to @sponce for digging this up). It remains to be seen whether dropping the type solves this for good or further action needs to be taken (looking at the TrackBestTrackCreator).

Goes with Rec!3722 (merged) and Allen!1396 (merged)

Resolves #339 (closed)

Edited by Andre Gunther

Merge request reports