Skip to content

Adapt options and tests to new particle table

Hendrik Jage requested to merge hjage_particle_table_tests into 2024-patches

Adapt option files and tests for the addition of helium3 to the standard particles and corresponding new hlt2-lines.

This MR is the equivalent to Moore!3533 (merged), with the following description copied from there:

The option to create helium3 is introduce to the functional particle maker in Rec!3855 (merged). At the same time the naming scheme for ions is updated to follow changes in Geant4 naming scheme, e.g. helium3 is renamed from He3[0.0] to He3. This change is applied to in the ParticleTable in DDDB in lhcb-conddb/DDDB!131 (merged) and to be ported to LHCb in LHCb!4579 (merged).

When using the functional particle maker, it is therefore important to use the ParticleTable with the new ion names. While this is no problem under DD4Hep, where the particle names are currently taken from LHCb, in DetDesc the still rely on DDDB, which is the reason for this MR.

To solve this, it is not possible to change the dddb_tag to the one with the updated particle table (dddb-20240427), as then e.g. geometry versions become incompatible.

On recommendation from @gcorti and @kreps, the following temporary solution is used:

New branches in DDDB (upgrade/dddb-202XXXXX-new-particle-table) have been created, starting from the needed older DDDB tags (upgrade/dddb-202XXXXX) and have been update to use the new ParticleTable. These new branches are used place of DDDB tags. This change is accompanied with a message that should make it clear that this change is temporary and can be reverted once new simulation samples, based on the new dddb-tag, are available to be used in the tests in place of the old ones.

# As dddb_tag a branch with a newer particle table version is used here,
# as some new hlt2 lines rely on new/renamed particles only introduced in dddb-20240427.
# This workaround is temporary and can be removed, once newer simulation samples,
# based on dddb-20240427 directly, are available for these tests.
Edited by Hendrik Jage

Merge request reports

Loading