Skip to content

Remove Hlt1GECPassthroughDecision

Ahmed Abdelmotteleb requested to merge ahabdelm-remove-gec-moore into master

Goes with Allen!1112 (merged) and MooreOnline!278 (merged)

Evidently, there are failing tests from the changes in Allen (need reference update). Also, there is one test which is crashing due to missing Hlt1GECPassthroughDecision, which no longer exists because of these lines here (we no longer enableGEC). Therefore, Hlt1GECPassthroughDecision was replaced with Hlt1PassthroughDecision in hlt_filters_test.py and the relevant test files (.qmt files).

Additionally, another test was failing because we no longer have hlt1_pp_no_gec_no_ut.py in the AllenSequences directory, so I just fixed it to use the now correct sequence file: hlt1_pp_no_ut.py (has no GEC by default)

Also, another test included hlt1_pp_forward_then_matching_and_downstream_no_gec that was renamed to remove the no_gec part as well. So that was changed accordingly.

Finally, as a cleanup, there were some hlt1 filters that were not used anywhere: "Hlt1.*fakeDecisions" and "Hlt1DummyDecision". So, I removed them because they do nothing and could be confusing.

Edited by Ahmed Abdelmotteleb

Merge request reports

Loading